Restore exception handling for IllegalArgumentException during type resolution#24981
Merged
pdabre12 merged 1 commit intoprestodb:masterfrom Apr 25, 2025
Merged
Restore exception handling for IllegalArgumentException during type resolution#24981pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12 merged 1 commit intoprestodb:masterfrom
Conversation
prestodb-ci
requested review from
a team,
Dilli-Babu-Godari and
ShahimSharafudeen
and removed request for
a team
Contributor
Author
|
@woshizhouyihao This could resolve the internal pipeline failure you are seeing. |
6 tasks
pdabre12
changed the title
pdabre12
changed the title
pdabre12
changed the title
Contributor
Author
|
@woshizhouyihao Will you be able to try this patch in your clusters? |
Contributor
|
Hi i m building a binary and deploying it. i will keep you updated |
Contributor
|
I have verified those failed queries succeeded with the new build. |
Contributor
|
@pdabre12 @woshizhouyihao I assume with this chance, we don't need to merge the two reverts |
rschlussel
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #24179, the exception thrown when a parsing an unknown type was replaced from
IllegalArgumentExceptionto a new ExceptionUnknownTypeException. As a result of this, exception handling forIllegalArgumentExceptionwas removed. ButIllegalArgumentExceptioncan be thrown at multiple places down that execution path, so this change adds exception handling forIllegalArgumentExceptionback.Motivation and Context
Solves the issue described in this PR: #24963
Impact
No Impact
Test Plan
Contributor checklist
Release Notes